Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(e2e): fixed some issues with e2e tests #4508

Merged
merged 2 commits into from
May 2, 2023
Merged

fix(e2e): fixed some issues with e2e tests #4508

merged 2 commits into from
May 2, 2023

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented May 1, 2023 •
edited
Loading

  • Solace e2e: Updated the chart url
  • Prometheus metrics: increased timeout and used a unique name for the metric label

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

@JorTurFer
fix: increase timeout and use a unique name for the metric label
6c0bbeb 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner May 1, 2023 21:26
@JorTurFer
Copy link
Member Author

JorTurFer commented May 1, 2023 •
edited by github-actions bot
Loading

/run-e2e prometheus
Update: You can check the progress here

@JorTurFer
fix solace e2e
7b430e4 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer changed the title fix(e2e): increase timeout and use a unique name for the metric label fix(e2e): fixed some issues with e2e tests May 1, 2023
@JorTurFer
Copy link
Member Author

JorTurFer commented May 1, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) May 2, 2023 06:37
@JorTurFer JorTurFer merged commit 90a1505 into kedacore:main May 2, 2023
@JorTurFer JorTurFer deleted the fix-prometheus-test branch May 2, 2023 08:40
@tomkerkhove
Copy link
Member

Oooh bloody auto-merge :)

Was going to re-run the tests again but let's see what main does :)

JorTurFer added a commit to JorTurFer/keda that referenced this pull request May 2, 2023
@JorTurFer
fix(e2e): fixed some issues with e2e tests (kedacore#4508)
9b48588
geoffrey1330 pushed a commit to geoffrey1330/keda that referenced this pull request Oct 4, 2023
@JorTurFer @geoffrey1330
fix(e2e): fixed some issues with e2e tests (kedacore#4508)
d8964de 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JorTurFer @tomkerkhove